| Summary: | Rename some JSC API functions/types. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, ggaren, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2018-07-30 10:33:40 PDT
Created attachment 346068 [details]
Patch
Attachment 346068 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:565: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:577: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:602: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 6 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 346068 [details] Patch Clearing flags on attachment: 346068 Committed r234381: <https://trac.webkit.org/changeset/234381> All reviewed patches have been landed. Closing bug. |