Bug 188143

Summary: Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch
none
Patch zalan: review+

Description Simon Fraser (smfr) 2018-07-28 21:54:30 PDT
Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs
Comment 1 Simon Fraser (smfr) 2018-07-28 21:56:26 PDT
Created attachment 346010 [details]
Patch
Comment 2 Darin Adler 2018-07-28 22:14:11 PDT
Comment on attachment 346010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346010&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:297
> +    NeverDestroyed<TransformationMatrix> identityTransform;

Need a "static" here!
Comment 3 EWS Watchlist 2018-07-28 23:05:19 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-07-28 23:05:21 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-07-28 23:12:35 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-07-28 23:12:37 PDT Comment hidden (obsolete)
Comment 7 Simon Fraser (smfr) 2018-07-29 08:46:05 PDT
Created attachment 346032 [details]
Patch
Comment 8 Simon Fraser (smfr) 2018-07-29 09:57:30 PDT
Created attachment 346033 [details]
Patch
Comment 9 Simon Fraser (smfr) 2018-07-30 09:38:02 PDT
https://trac.webkit.org/changeset/234368/webkit
Comment 10 Radar WebKit Bug Importer 2018-07-30 09:43:03 PDT
<rdar://problem/42735167>