Bug 188128

Summary: Web Inspector: Dark Mode: Search sidebar panel text field has a white background
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Search sidebar panel text field
none
Patch
none
[Video] With patch applied
none
Patch
mattbaker: review+
Patch none

Description Matt Baker 2018-07-27 15:53:58 PDT
Created attachment 345962 [details]
[Image] Search sidebar panel text field

Summary:
Search sidebar panel text field has a white background.

- After performing a global search the field is populated, but the text isn't visible against the white background.
Comment 1 Radar WebKit Bug Importer 2018-07-27 15:54:26 PDT
<rdar://problem/42678270>
Comment 2 Nikita Vasilyev 2018-07-30 11:24:59 PDT
Created attachment 346074 [details]
Patch
Comment 3 Nikita Vasilyev 2018-07-30 11:26:39 PDT
Created attachment 346075 [details]
[Video] With patch applied
Comment 4 Nikita Vasilyev 2018-07-30 11:29:04 PDT
Created attachment 346076 [details]
Patch
Comment 5 Matt Baker 2018-07-30 12:49:25 PDT
Comment on attachment 346076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346076&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DarkMode.css:919
>      /* FilterBar.css */

Nit: update the comment to /* FilterBar.css, SearchBar.css */
Comment 6 Nikita Vasilyev 2018-07-30 13:13:57 PDT
Created attachment 346090 [details]
Patch
Comment 7 WebKit Commit Bot 2018-07-30 16:11:03 PDT
Comment on attachment 346090 [details]
Patch

Clearing flags on attachment: 346090

Committed r234394: <https://trac.webkit.org/changeset/234394>
Comment 8 WebKit Commit Bot 2018-07-30 16:11:05 PDT
All reviewed patches have been landed.  Closing bug.