| Summary: | [iOS] Don't deactivate audio session | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, jonlee, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Eric Carlson
2018-07-27 15:53:44 PDT
Created attachment 345966 [details]
Patch
Comment on attachment 345966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345966&action=review > Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:-167 > -#endif Can we write a test for this? Comment on attachment 345966 [details] Patch Clearing flags on attachment: 345966 Committed r234339: <https://trac.webkit.org/changeset/234339> All reviewed patches have been landed. Closing bug. Comment on attachment 345966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345966&action=review > Source/WebCore/ChangeLog:12 > + r233435 includes a change that deactivates the shared audio session when there are no more > + active media sessions. This is a good in WK2 because it allows other applications to resume > + playing audio when WebKit stops playing, but it is potentially bad in WK1 where the host > + app may also be playing audio. So why didn’t we keep it for WK2? Comment on attachment 345966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345966&action=review >> Source/WebCore/ChangeLog:12 >> + app may also be playing audio. > > So why didn’t we keep it for WK2? I filed rdar://42678977 to add it back for WK2, but there are potential issues we need to investigate first (eg. rdar://42672521, rdar://42267132). (In reply to Eric Carlson from comment #7) > Comment on attachment 345966 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345966&action=review > > >> Source/WebCore/ChangeLog:12 > >> + app may also be playing audio. > > > > So why didn’t we keep it for WK2? > > I filed rdar://42678977 to add it back for WK2, but there are potential > issues we need to investigate first (eg. rdar://42672521, rdar://42267132). Fixed in bug 193188. |