Bug 188123

Summary:

Add some crash info to Heap::checkConn() RELEASE_ASSERTs.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	keith_miller: review+
patch for landing.	none

Description Mark Lam 2018-07-27 13:26:26 PDT

This is needed to help debug a crash.

<rdar://problem/42672268>

Comment 1 Mark Lam 2018-07-27 14:04:40 PDT

Created attachment 345951 [details]
proposed patch.

Comment 2 EWS Watchlist 2018-07-27 14:07:11 PDT

Attachment 345951 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Assertions.cpp:607:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:619:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:630:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:640:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:649:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:657:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:664:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:670:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:670:  Extra space before )  [whitespace/parens] [2]
Total errors found: 9 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Mark Lam 2018-07-27 14:12:57 PDT

Comment on attachment 345951 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345951&action=review

> Source/JavaScriptCore/ChangeLog:22
> +           VM::isEntered() tells us is the current VM is currently executing JS code.

/is/if/.  Will fix before landing.

Comment 4 Keith Miller 2018-07-27 14:29:24 PDT

Comment on attachment 345951 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345951&action=review

r=me.

> Source/JavaScriptCore/ChangeLog:10
> +           padding space in VM and Heap, and should cost any measurable perf to initialize

should *only* cost?

> Source/WTF/wtf/Assertions.cpp:676
> +void WTFCrashWithInfo(int, const char*, const char*, int, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t) { CRASH(); }

I think you need another line here.

Comment 5 Mark Lam 2018-07-27 14:37:11 PDT

Comment on attachment 345951 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345951&action=review

Thanks for the review.

>> Source/JavaScriptCore/ChangeLog:10
>> +           padding space in VM and Heap, and should cost any measurable perf to initialize
> 
> should *only* cost?

I meant to say "should not cost"

>> Source/WTF/wtf/Assertions.cpp:676
>> +void WTFCrashWithInfo(int, const char*, const char*, int, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t) { CRASH(); }
> 
> I think you need another line here.

Fixed.

Comment 6 Mark Lam 2018-07-27 14:39:55 PDT

Created attachment 345955 [details]
patch for landing.

Comment 7 EWS Watchlist 2018-07-27 14:41:56 PDT

Attachment 345955 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Assertions.cpp:607:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:619:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:630:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:640:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:649:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:657:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:664:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:670:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/Assertions.cpp:670:  Extra space before )  [whitespace/parens] [2]
Total errors found: 9 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 Mark Lam 2018-07-27 15:45:33 PDT

Landed in r234335: <http://trac.webkit.org/r234335>.

Comment 9 Mark Lam 2018-07-28 09:36:22 PDT

Build fix for internal build landed in r234344: <http://trac.webkit.org/r234344>.