Bug 188097

Summary: Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187284    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2018-07-27 10:45:17 PDT 
Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable(). RealtimeMediaSource::audioSamplesAvailable() is called on a background thread but iterates over observers that may get destroyed concurrently on the main thread.
Comment 1 Chris Dumez 2018-07-27 11:05:10 PDT 
<rdar://problem/42558823>
Comment 2 Chris Dumez 2018-07-27 13:02:03 PDT 
Created attachment 345943 [details]
Patch
Comment 3 Chris Dumez 2018-07-27 13:53:37 PDT 
Created attachment 345950 [details]
Patch
Comment 4 WebKit Commit Bot 2018-07-27 15:33:58 PDT 
Comment on attachment 345950 [details]
Patch

Clearing flags on attachment: 345950

Committed r234334: <https://trac.webkit.org/changeset/234334>
Comment 5 WebKit Commit Bot 2018-07-27 15:34:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-27 15:34:34 PDT 
<rdar://problem/42677538>