Bug 188082

Summary: Web Inspector: REGRESSION (r233824): execution highlight range missing/incorrect in pretty printed code
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Webarchive] reduced test case
none
Patch none

Description Matt Baker 2018-07-26 15:27:21 PDT 
Created attachment 345881 [details]
[Webarchive] reduced test case

Summary:
Execution highlight range missing/incorrect in pretty printed code.

Regressed in http://trac.webkit.org/changeset/233824.

Steps to Reproduce:
1. Inspect the attached webarchive
2. View chained-property-stepping-min.js in Debugger tab
3. Enable pretty printing
4. Set breakpoint at line 13
5. Reload page
  => Paused in debugger

Expected:
  => Expression-level execution highlight: |return 42|

Actual:
  => Expression-level execution highlight missing (whole line is highlighted)
Comment 1 Radar WebKit Bug Importer 2018-07-26 15:27:50 PDT 
<rdar://problem/42640580>
Comment 2 Matt Baker 2018-10-12 17:56:38 PDT 
Created attachment 352246 [details]
Patch
Comment 3 Joseph Pecoraro 2018-10-15 13:55:59 PDT 
Comment on attachment 352246 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-10-15 14:21:25 PDT 
Comment on attachment 352246 [details]
Patch

Clearing flags on attachment: 352246

Committed r237145: <https://trac.webkit.org/changeset/237145>
Comment 5 WebKit Commit Bot 2018-10-15 14:21:27 PDT 
All reviewed patches have been landed.  Closing bug.