Bug 188058

Summary: [WPE] webanimations/partly-accelerated-transition-by-removing-property.html is failing since added in r234250 "[Web Animations] REGRESSION: transition added immediately after element creation doesn't work"
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WPE WebKitAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, graouts
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Miguel Gomez 2018-07-26 08:08:09 PDT 
webanimations/partly-accelerated-transition-by-removing-property.html [ Failure ]

The test fails cause the expectation is empty: it's a dump of the layer tree and there are no layers. But on WPE there are layers. This is the diff

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/webanimations/partly-accelerated-transition-by-removing-property-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/webanimations/partly-accelerated-transition-by-removing-property-actual.txt
@@ -1 +1,11 @@
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (children 1
+    (GraphicsLayer
+      (bounds 800.00 600.00)
+      (contentsOpaque 1)
+    )
+  )
+)

I suspect this is just because WPE is always in accelerated compositing mode, and the test expects that removing the animation will cause webkit to leave AC mode. I'll check this and update the expectations if that's the case.
Comment 1 Miguel Gomez 2018-07-31 02:59:02 PDT 
Created attachment 346148 [details]
Patch
Comment 2 Miguel Gomez 2018-07-31 02:59:35 PDT 
Created attachment 346149 [details]
Patch
Comment 3 WebKit Commit Bot 2018-07-31 03:39:44 PDT 
Comment on attachment 346149 [details]
Patch

Clearing flags on attachment: 346149

Committed r234421: <https://trac.webkit.org/changeset/234421>
Comment 4 WebKit Commit Bot 2018-07-31 03:39:45 PDT 
All reviewed patches have been landed.  Closing bug.