| Summary: | Mask AVBackgroundView to the corner radius. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, fred.wang, jonlee, sam, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jeremy Jones
2018-07-24 15:36:18 PDT
Created attachment 345721 [details]
Patch
Comment on attachment 345721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review > Source/WebKit/ChangeLog:12 > + This changes sets the appropriate mask to the layer so the corners look correct. > + > + * UIProcess/ios/fullscreen/WKFullscreenStackView.mm: > + (-[WKFullscreenStackView init]): How can this be tested? Comment on attachment 345721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63 > + [_backgroundView setClipsToBounds:YES]; Please add a FIXME for reverting this workaround. (In reply to Jon Lee from comment #4) > Comment on attachment 345721 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345721&action=review > > > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63 > > + [_backgroundView setClipsToBounds:YES]; > > Please add a FIXME for reverting this workaround. Added bugzilla bug for the cleanup: https://bugs.webkit.org/show_bug.cgi?id=188022 Created attachment 345785 [details]
Patch for landing.
(In reply to Sam Weinig from comment #3) > Comment on attachment 345721 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345721&action=review > > > Source/WebKit/ChangeLog:12 > > + This changes sets the appropriate mask to the layer so the corners look correct. > > + > > + * UIProcess/ios/fullscreen/WKFullscreenStackView.mm: > > + (-[WKFullscreenStackView init]): > > How can this be tested? We don't have a way to test this. Comment on attachment 345785 [details] Patch for landing. Clearing flags on attachment: 345785 Committed r234216: <https://trac.webkit.org/changeset/234216> Comment on attachment 345785 [details] Patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=345785&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:65 > + [_backgroundView.get().layer setContinuousCorners:YES]; For the record, this is causing build failure with XCode 10 (public SDK). I opened https://bugs.webkit.org/show_bug.cgi?id=189786 |