Bug 187968

Summary: Refactoring: make DFG::Plan a class.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
saam: review+
patch for landing. none

Mark Lam
Reported 2018-07-24 12:26:40 PDT
Let's make all the fields private, and provide accessor methods for them. This makes it easier to reason about how these fields are used and modified.
Attachments
proposed patch. (96.98 KB, patch)
2018-07-24 12:40 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
patch for landing. (97.74 KB, patch)
2018-07-24 15:03 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-07-24 12:40:18 PDT
Created attachment 345702 [details] proposed patch.
EWS Watchlist
Comment 2 2018-07-24 12:42:17 PDT
Attachment 345702 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:139: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:140: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:141: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:142: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:143: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:145: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:146: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:147: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:148: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:149: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:224: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 12 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2018-07-24 12:48:27 PDT
Comment on attachment 345702 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345702&action=review r=me > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:574 > + if (!isFTL(m_graph.m_plan.mode())) might be nice to have a function like: bool Plan::isFTL()
Mark Lam
Comment 4 2018-07-24 13:33:20 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 345702 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345702&action=review > > r=me > > > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:574 > > + if (!isFTL(m_graph.m_plan.mode())) > > might be nice to have a function like: > > bool Plan::isFTL() Good suggestion. I'll make the change.
Mark Lam
Comment 5 2018-07-24 15:03:29 PDT
Created attachment 345717 [details] patch for landing.
EWS Watchlist
Comment 6 2018-07-24 15:05:27 PDT
Attachment 345717 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:139: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:140: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:141: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:142: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:143: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:145: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:146: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:147: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:148: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:149: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:224: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 12 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 7 2018-07-24 16:14:44 PDT
Landed in r234178: <http://trac.webkit.org/r234178>.
Radar WebKit Bug Importer
Comment 8 2018-07-24 16:15:17 PDT
<rdar://problem/42560897>
Note You need to log in before you can comment on or make changes to this bug.