| Summary: | [WTF] String::formatWithArguments() is unused | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tomas Popela <tpopela> | ||||||
| Component: | Web Template Framework | Assignee: | Tomas Popela <tpopela> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 30342 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tomas Popela
2018-07-24 04:44:20 PDT
Created attachment 345659 [details]
Patch
Created attachment 345668 [details]
Patch
After doing this we should rename String::format to String::deprecatedFormat and start phasing it out. Clients can and should use string concatenation, clearly invokable as makeString or possibly just with the + operator, instead. More efficient, likely safer. A few clients might be using advanced features of printf, but even those could probably be added to the concatenation. (In reply to Darin Adler from comment #3) > After doing this we should rename String::format to String::deprecatedFormat > and start phasing it out. Clients can and should use string concatenation, > clearly invokable as makeString or possibly just with the + operator, > instead. More efficient, likely safer. A few clients might be using advanced > features of printf, but even those could probably be added to the > concatenation. Thank you for the review Darin! I open bug 188191 for that. Committed r234411: <https://trac.webkit.org/changeset/234411> |