Bug 187925

Summary: Add test for fix in https://bugs.webkit.org/show_bug.cgi?id=187922
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch none

Description Per Arne Vollan 2018-07-23 14:34:48 PDT 
See comments in https://bugs.webkit.org/show_bug.cgi?id=187922 for how to test this.
Comment 1 Per Arne Vollan 2018-08-31 10:51:20 PDT 
Created attachment 348651 [details]
Patch
Comment 2 Per Arne Vollan 2018-08-31 13:24:22 PDT 
Thanks for reviewing!
Comment 3 Per Arne Vollan 2018-09-04 09:34:23 PDT 
Created attachment 348817 [details]
Patch
Comment 4 Per Arne Vollan 2018-09-04 11:04:46 PDT 
Committed r235619: <https://trac.webkit.org/changeset/235619/webkit>
Comment 5 Radar WebKit Bug Importer 2018-09-04 11:05:28 PDT 
<rdar://problem/44103708>
Comment 6 Darin Adler 2018-09-08 18:38:53 PDT 
Comment on attachment 348817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348817&action=review

> Source/WebCore/testing/Internals.cpp:4724
> +unsigned long Internals::primaryScreenDisplayID()

This should be "unsigned". IDL "unsigned long" corresponds to C++ "unsigned".

> Source/WebCore/testing/Internals.h:738
> +    unsigned long primaryScreenDisplayID();

"unsigned"

> Source/WebCore/testing/Internals.idl:673
> +    unsigned long primaryScreenDisplayID();

"unsigned"
Comment 7 Per Arne Vollan 2018-09-11 15:10:51 PDT 
(In reply to Darin Adler from comment #6)
> Comment on attachment 348817 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348817&action=review
> 
> > Source/WebCore/testing/Internals.cpp:4724
> > +unsigned long Internals::primaryScreenDisplayID()
> 
> This should be "unsigned". IDL "unsigned long" corresponds to C++ "unsigned".
> 
> > Source/WebCore/testing/Internals.h:738
> > +    unsigned long primaryScreenDisplayID();
> 
> "unsigned"
> 
> > Source/WebCore/testing/Internals.idl:673
> > +    unsigned long primaryScreenDisplayID();
> 
> "unsigned"

Thanks! I'll change this.
Comment 8 Per Arne Vollan 2018-09-11 15:39:56 PDT 
Committed r235916: <https://trac.webkit.org/changeset/235916/webkit>