| Summary: | DisplayList::DrawRect() should take half of the border thickness into account when calculating the localBounds. | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||||||
| Status: | NEW --- | ||||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, ews-watchlist, jonlee, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Bug Depends on: | 187898 | ||||||||||||||||||||
| Bug Blocks: | 187980 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Said Abou-Hallawa
2018-07-23 13:52:39 PDT
Created attachment 345606 [details]
Patch
These patches are impossible to review. I want to r- the templatization patch Created attachment 345607 [details]
Patch for Review
(In reply to Simon Fraser (smfr) from comment #2) > These patches are impossible to review. I want to r- the templatization patch I have not asked for review yet for these patches (I mean getting r- or r+ for them). I will do that once I confirm we are getting a progression on MotionMark from this work, which should happen soon. But you can add your comments you want in the patch named "Patch for Review". This patch has only the difference between the EWS patch of this bug and the EWS patch of the https://bugs.webkit.org/show_bug.cgi?id=187898. I did not understand why you "want to r- the templatization patch" https://bugs.webkit.org/show_bug.cgi?id=187002. I think I answered all your concerns and the last patch succeeded to pass the compilation on all ports. So if you still have other concerns please add them there and I will be happy to answer them. Or I will change the approach if the current patch can't be changed to answer your concern. Comment on attachment 345606 [details] Patch Attachment 345606 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8631039 New failing tests: displaylists/layer-dispay-list.html Created attachment 345615 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 345606 [details] Patch Attachment 345606 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8630947 New failing tests: displaylists/layer-dispay-list.html Created attachment 345616 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 345606 [details] Patch Attachment 345606 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8631271 New failing tests: displaylists/layer-dispay-list.html Created attachment 345620 [details]
Archive of layout-test-results from ews112 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 345699 [details]
Patch
Comment on attachment 345699 [details] Patch Attachment 345699 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8641270 New failing tests: accessibility/smart-invert-reference.html Created attachment 345706 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 345708 [details]
Patch for Review
(In reply to Said Abou-Hallawa from comment #4) > (In reply to Simon Fraser (smfr) from comment #2) > > These patches are impossible to review. I want to r- the templatization patch > > I have not asked for review yet for these patches (I mean getting r- or r+ > for them). I will do that once I confirm we are getting a progression on > MotionMark from this work, which should happen soon. > It would be helpful if the patches were labeled as "Patch for EWS" or "WIP Patch". |