Bug 187903

Summary: Table caption jumps to the bottom of the table after simplified table relayout
Product: WebKit Reporter: Denys <webschik>
Component: TablesAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Major CC: bfulgham, changseok, don.olmstead, emailmkumaran, esprehn+autocc, ews-watchlist, glenn, heycam, Hironori.Fujii, jonesr, kondapallykalyan, ladrien2, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari 11   
Hardware: Mac   
OS: macOS 10.12   
See Also: https://bugs.webkit.org/show_bug.cgi?id=164284
Attachments:
Description Flags
another test case
none
WIP patch
none
WIP patch
none
Patch none

Description Denys 2018-07-23 05:11:04 PDT 
Environment:

Safari: 11.1.1 (12605.2.8)
macOS Sierra: 10.12.6 (16G1408)

Bug description:

When <table> has a positioned child element (or an element that creates a new stacking context), and we hide/show this element, the table <caption> element starts jumping to the bottom of the table and back.


How to reproduce:

1) Go to https://codepen.io/webschik/pen/ZjeqBg
2) Move a cursor to the table cell to show the popup element and see how table <caption> behaves.
Comment 1 Radar WebKit Bug Importer 2018-07-23 10:58:22 PDT 
<rdar://problem/42506245>
Comment 2 Denys 2021-01-28 09:14:12 PST 
This issue is still reproducible in Safari 14.0.2 (15610.3.7.1.10, 15610)
Comment 3 mkumaran 2021-04-05 04:27:32 PDT 
Issue still exist on Safari Version 14.0.3 (15610.4.3.1.6, 15610).
Comment 4 Fujii Hironori 2021-04-07 23:32:01 PDT 
Created attachment 425479 [details]
another test case
Comment 5 Fujii Hironori 2021-04-08 00:13:51 PDT 
Created attachment 425480 [details]
WIP patch

resetLogicalHeightBeforeLayoutIfNeeded doesn't seem to be called in the simplifiedLayout code path.
Comment 6 Fujii Hironori 2021-04-08 19:49:11 PDT 
Created attachment 425575 [details]
WIP patch
Comment 7 Fujii Hironori 2021-04-08 23:01:25 PDT 
Created attachment 425587 [details]
Patch
Comment 8 Fujii Hironori 2021-04-13 12:37:13 PDT 
Could anyone review?
Comment 9 Fujii Hironori 2021-04-13 22:34:40 PDT 
Comment on attachment 425587 [details]
Patch

Clearing flags on attachment: 425587

Committed r275931 (236493@main): <https://commits.webkit.org/236493@main>
Comment 10 Fujii Hironori 2021-04-13 22:34:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 renadr 2021-06-11 09:03:08 PDT 
I still have this issue on safari 14.1.

The caption is still displayed on top but an invisible space shows up at the end. And when I look at this with the devtool it's highlighting the caption.
Comment 12 renadr 2021-06-11 09:05:42 PDT 
I forgot to tell that in my case it's like that. But if I use the given codepen on Safari, I still have the same bug as @Denys !
Comment 13 Fujii Hironori 2021-06-13 13:06:26 PDT 
Right. It seems that Safari 14.1 doesn't include the fix.
Please try the latest Safari Technology Preview 125.
https://developer.apple.com/safari/technology-preview/