Bug 187902

Summary: [css-grid] Add support for calc() in gutter properties
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jfernandez, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=816300
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Manuel Rego Casasnovas 2018-07-23 04:33:28 PDT
[css-grid] Add support for calc() in gutter properties
Comment 1 Manuel Rego Casasnovas 2018-07-23 04:34:09 PDT
Created attachment 345568 [details]
Patch
Comment 2 WebKit Commit Bot 2018-07-23 12:44:03 PDT
Comment on attachment 345568 [details]
Patch

Rejecting attachment 345568 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 345568, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/8629556
Comment 3 Manuel Rego Casasnovas 2018-07-23 21:10:26 PDT
Created attachment 345635 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-07-23 21:50:27 PDT
Comment on attachment 345635 [details]
Patch for landing

Clearing flags on attachment: 345635

Committed r234131: <https://trac.webkit.org/changeset/234131>
Comment 5 WebKit Commit Bot 2018-07-23 21:50:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-23 21:51:19 PDT
<rdar://problem/42528531>