Bug 187897

Summary:

fullscreen env() variables should have initial values

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, dbates, esprehn+autocc, ews-watchlist, jonlee, kangil.han, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Dean Jackson 2018-07-22 18:39:56 PDT

fullscreen env() variables should have initial values

Comment 1 Radar WebKit Bug Importer 2018-07-22 18:40:38 PDT

<rdar://problem/42485682>

Comment 2 Dean Jackson 2018-07-22 18:47:44 PDT

Created attachment 345551 [details]
Patch

Comment 3 Dean Jackson 2018-07-23 09:54:10 PDT

Committed r234098: <https://trac.webkit.org/changeset/234098>

Comment 4 Darin Adler 2018-07-23 10:58:20 PDT

Comment on attachment 345551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345551&action=review

> Source/WebCore/page/Page.h:358
> +    const Seconds fullscreenAutoHideDuration() const { return m_fullscreenAutoHideDuration; }

The "const" at the beginning of the line here is not needed.