| Summary: | Add alternative bmalloc Scavenger logging that is machine-readable | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, rniwa, saam, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2018-07-21 11:23:39 PDT
Created attachment 345515 [details]
Patch
My std::chrono fu is too weak to figure out how to print current time at a resolution finer than seconds. This is also useful for dumping the GC heap size:
diff --git a/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm b/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm
index 7d170433bfc8577c5d28dc513f1458f3f1af5cd8..ede9bd65936e85817b5383a6b9f6f3253c9bbff5 100644
--- a/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm
+++ b/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm
@@ -29,6 +29,7 @@
#import "GCController.h"
#import "IOSurfacePool.h"
#import "LayerPool.h"
+#import "PerformanceLogging.h"
#import <notify.h>
#import <pal/spi/ios/GraphicsServicesSPI.h>
@@ -93,6 +94,10 @@ void registerMemoryReleaseNotifyCallbacks()
GCController::singleton().deleteAllCode(JSC::PreventCollectionAndDeleteAllCode);
GCController::singleton().garbageCollectNow();
});
+ notify_register_dispatch("com.apple.WebKit.dumpGCStats", &dummy, dispatch_get_main_queue(), ^(int) {
+ for (auto& it : PerformanceLogging::memoryUsageStatistics(ShouldIncludeExpensiveComputations::Yes))
+ WTFLogAlways("%s %lu", it.key, it.value);
+ });
});
}
Comment on attachment 345515 [details] Patch Attachment 345515 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8610483 New failing tests: accessibility/smart-invert-reference.html Created attachment 345516 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 345515 [details] Patch Attachment 345515 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8611728 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html http/tests/security/video-poster-cross-origin-crash2.html Created attachment 345520 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 345515 [details]
Patch
r=me
|