Bug 187881

Summary: Add alternative bmalloc Scavenger logging that is machine-readable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW    
Severity: Normal CC: ews-watchlist, rniwa, saam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
saam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews205 for win-future none

Simon Fraser (smfr)
Reported 2018-07-21 11:23:39 PDT
Add alternative bmalloc Scavenger logging that is machine-readable
Attachments
Patch (6.85 KB, patch)
2018-07-21 11:25 PDT, Simon Fraser (smfr) 		saam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.09 MB, application/zip)
2018-07-21 12:37 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews205 for win-future (12.91 MB, application/zip)
2018-07-21 16:44 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-07-21 11:25:13 PDT
Created attachment 345515 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-07-21 11:33:57 PDT
My std::chrono fu is too weak to figure out how to print current time at a resolution finer than seconds.
Simon Fraser (smfr)
Comment 3 2018-07-21 12:25:31 PDT
This is also useful for dumping the GC heap size: diff --git a/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm b/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm index 7d170433bfc8577c5d28dc513f1458f3f1af5cd8..ede9bd65936e85817b5383a6b9f6f3253c9bbff5 100644 --- a/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm +++ b/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm @@ -29,6 +29,7 @@ #import "GCController.h" #import "IOSurfacePool.h" #import "LayerPool.h" +#import "PerformanceLogging.h" #import <notify.h> #import <pal/spi/ios/GraphicsServicesSPI.h> @@ -93,6 +94,10 @@ void registerMemoryReleaseNotifyCallbacks() GCController::singleton().deleteAllCode(JSC::PreventCollectionAndDeleteAllCode); GCController::singleton().garbageCollectNow(); }); + notify_register_dispatch("com.apple.WebKit.dumpGCStats", &dummy, dispatch_get_main_queue(), ^(int) { + for (auto& it : PerformanceLogging::memoryUsageStatistics(ShouldIncludeExpensiveComputations::Yes)) + WTFLogAlways("%s %lu", it.key, it.value); + }); }); }
EWS Watchlist
Comment 4 2018-07-21 12:37:56 PDT
Comment on attachment 345515 [details] Patch Attachment 345515 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8610483 New failing tests: accessibility/smart-invert-reference.html
EWS Watchlist
Comment 5 2018-07-21 12:37:58 PDT
Created attachment 345516 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-07-21 16:44:17 PDT
Comment on attachment 345515 [details] Patch Attachment 345515 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8611728 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html http/tests/security/video-poster-cross-origin-crash2.html
EWS Watchlist
Comment 7 2018-07-21 16:44:30 PDT
Created attachment 345520 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Saam Barati
Comment 8 2018-07-23 11:18:44 PDT
Comment on attachment 345515 [details] Patch r=me
Note You need to log in before you can comment on or make changes to this bug.