Bug 187879

Summary: [LFC][IFC] Add verification for inline text runs.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch koivisto: review+

Description zalan 2018-07-20 21:23:57 PDT
against simple and complex runs.
Comment 1 zalan 2018-07-20 21:26:01 PDT
Created attachment 345499 [details]
Patch
Comment 2 zalan 2018-07-20 21:33:09 PDT
Created attachment 345500 [details]
Patch
Comment 3 EWS Watchlist 2018-07-20 21:36:20 PDT
Attachment 345500 [details] did not pass style-queue:


ERROR: Source/WebCore/layout/inlineformatting/InlineFormattingState.h:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 zalan 2018-07-20 21:37:58 PDT
Created attachment 345501 [details]
Patch
Comment 5 EWS Watchlist 2018-07-20 21:39:22 PDT
Attachment 345501 [details] did not pass style-queue:


ERROR: Source/WebCore/layout/inlineformatting/InlineFormattingState.h:50:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 zalan 2018-07-20 21:40:30 PDT
Created attachment 345502 [details]
Patch
Comment 7 zalan 2018-07-21 11:49:29 PDT
Committed r234085: <https://trac.webkit.org/changeset/234085>
Comment 8 Radar WebKit Bug Importer 2018-07-21 11:50:19 PDT
<rdar://problem/42467004>