Bug 187875

Summary: [LFC] Do not use virtual methods to construct floating/formatting states.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews205 for win-future none

Description zalan 2018-07-20 16:57:53 PDT
it just makes the code more complicated.
Comment 1 zalan 2018-07-20 18:42:11 PDT
Created attachment 345496 [details]
Patch
Comment 2 zalan 2018-07-20 18:48:09 PDT
Created attachment 345497 [details]
Patch
Comment 3 EWS Watchlist 2018-07-20 22:37:03 PDT
Comment on attachment 345497 [details]
Patch

Attachment 345497 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8606179

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 4 EWS Watchlist 2018-07-20 22:37:14 PDT
Created attachment 345506 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 zalan 2018-07-21 11:47:08 PDT
Committed r234084: <https://trac.webkit.org/changeset/234084>
Comment 6 Radar WebKit Bug Importer 2018-07-21 11:49:11 PDT
<rdar://problem/42467000>