| Summary: | REGRESSION (r233974): Cannot close pip'd video; pops back into PiP. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, jeremyj-wk, jonlee, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2018-07-20 15:53:24 PDT
Created attachment 345485 [details]
Patch
Comment on attachment 345485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345485&action=review > Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:-338 > - // FIXME 25096170: Should animate only if the page with the video is unobscured. For now, always close without animation. If this comment is going away, are we closing the associated also? (In reply to Jon Lee from comment #3) > Comment on attachment 345485 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345485&action=review > > > Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:-338 > > - // FIXME 25096170: Should animate only if the page with the video is unobscured. For now, always close without animation. > > If this comment is going away, are we closing the associated also? That comment was never right; this method only gets called when the "stop" button is clicked, so there is no animation. Comment on attachment 345485 [details] Patch Clearing flags on attachment: 345485 Committed r234078: <https://trac.webkit.org/changeset/234078> All reviewed patches have been landed. Closing bug. |