| Summary: | [WinCairo] Fix detection of held modifier keys for key events | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Stephan Szabo <stephan.szabo> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, Hironori.Fujii, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Stephan Szabo
2018-07-20 10:29:28 PDT
We were always checking VK_MENU when checking if IsKeyInDownState rather than the requested modifier. Created attachment 345460 [details]
Use requested key in IsKeyInDownState
Comment on attachment 345460 [details] Use requested key in IsKeyInDownState Attachment 345460 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8607279 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 345508 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Win bot appears to be failing both with and without the patch with similar results. Comment on attachment 345460 [details] Use requested key in IsKeyInDownState Clearing flags on attachment: 345460 Committed r234103: <https://trac.webkit.org/changeset/234103> All reviewed patches have been landed. Closing bug. |