Bug 187844

Summary: Remove completed animations from GraphicsLayer, thus avoiding excessive backing store allocation
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, dino, dstockwell, ews-watchlist, graouts, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Description Simon Fraser (smfr) 2018-07-19 19:59:07 PDT
Remove completed animations from GraphicsLayer, thus avoiding excessive backing store allocation
Comment 1 Simon Fraser (smfr) 2018-07-19 20:06:01 PDT
Created attachment 345421 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-07-19 20:06:33 PDT
rdar://problem/40387294
Comment 3 Simon Fraser (smfr) 2018-07-19 20:25:16 PDT
Created attachment 345422 [details]
Patch
Comment 4 EWS Watchlist 2018-07-19 22:18:26 PDT
Comment on attachment 345422 [details]
Patch

Attachment 345422 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8595479

New failing tests:
compositing/backing/backing-store-attachment-fill-forwards-animation.html
Comment 5 EWS Watchlist 2018-07-19 22:18:27 PDT
Created attachment 345427 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 Dean Jackson 2018-07-20 10:03:54 PDT
Comment on attachment 345422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345422&action=review

> Source/WebCore/page/animation/KeyframeAnimation.cpp:300
> +void KeyframeAnimation::endAnimation(bool fillingForwards)

You say fillForwards in other places.
Comment 7 Simon Fraser (smfr) 2018-07-20 16:34:15 PDT
https://trac.webkit.org/changeset/234073/webkit