| Summary: | Reduce getters/setters in WebFramePolicyListenerProxy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, dino, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2018-07-19 17:07:56 PDT
Created attachment 345404 [details]
Patch
Comment on attachment 345404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345404&action=review > Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:54 > +enum class ShouldProcessSwapIfPossible { No, Yes }; Shouldn't this be ShouldProcessSwap { DoNotProcess, ProcessIfPossible } ? (In reply to Dean Jackson from comment #2) > Comment on attachment 345404 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345404&action=review > > > Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:54 > > +enum class ShouldProcessSwapIfPossible { No, Yes }; > > Shouldn't this be ShouldProcessSwap { DoNotProcess, ProcessIfPossible } ? DoNotProcess / ProcessIfPossible do not make sense. This is not about processing about about process swapping. |