Bug 187795

Summary: Clipping operations should be platform-independent GraphicsContext functions
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: NEW ---    
Severity: Normal CC: ahmad.saleem792, bfulgham, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 187765    
Bug Blocks: 187841    
Attachments:
Description Flags
Patch for EWS
none
Patch for EWS
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Archive of layout-test-results from ews201 for win-future
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Patch for EWS
none
Patch for Review none

Description Said Abou-Hallawa 2018-07-18 18:19:36 PDT
Recording to DisplayList list happens in the platform-independent APIs. The actual clipping will be done in the platform-dependent sources.
Comment 1 Said Abou-Hallawa 2018-07-18 18:23:49 PDT
Created attachment 345315 [details]
Patch for EWS
Comment 2 Said Abou-Hallawa 2018-07-18 18:51:24 PDT
Created attachment 345316 [details]
Patch for EWS
Comment 3 EWS Watchlist 2018-07-18 21:33:10 PDT
Comment on attachment 345316 [details]
Patch for EWS

Attachment 345316 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8582684

New failing tests:
css3/blending/background-blend-mode-body-image.html
css3/blending/background-blend-mode-separate-layer-declaration.html
css3/blending/background-blend-mode-svg.html
css3/blending/background-blend-mode-background-clip-content-box.html
css3/blending/background-blend-mode-body-transparent-color-and-image.html
css3/blending/background-blend-mode-crossfade-image.html
css3/blending/background-blend-mode-background-repeat-no-repeat.html
css3/blending/background-blend-mode-background-attachement-fixed.html
css3/blending/background-blend-mode-background-size-cover.html
css3/blending/background-blend-mode-background-size-contain.html
css3/blending/background-blend-mode-tiled-layers.html
imported/blink/css3/blending/background-blend-mode-background-size-percentage.html
css3/blending/background-blend-mode-body-transparent-image.html
css3/blending/background-blend-mode-image-color-dynamic.html
css3/blending/background-blend-mode-background-clip-padding-box.html
imported/blink/css3/blending/background-blend-mode-background-size-pixels.html
css3/blending/background-blend-mode-data-uri-svg-image.html
css3/blending/background-blend-mode-background-origin-border-box.html
imported/blink/paint/masks/table-cell-masks.html
css3/blending/background-blend-mode-background-position-percentage.html
imported/blink/css3/blending/background-blend-mode-background-origin-content-box.html
Comment 4 EWS Watchlist 2018-07-18 21:33:11 PDT
Created attachment 345325 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 5 EWS Watchlist 2018-07-18 23:15:33 PDT
Comment on attachment 345316 [details]
Patch for EWS

Attachment 345316 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8583534

New failing tests:
http/tests/preload/onload_event.html
Comment 6 EWS Watchlist 2018-07-18 23:15:44 PDT
Created attachment 345333 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 EWS Watchlist 2018-07-18 23:31:43 PDT
Comment on attachment 345316 [details]
Patch for EWS

Attachment 345316 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8583491

New failing tests:
css3/blending/background-blend-mode-body-image.html
css3/blending/background-blend-mode-separate-layer-declaration.html
css3/blending/background-blend-mode-svg.html
css3/blending/background-blend-mode-background-clip-content-box.html
css3/blending/background-blend-mode-body-transparent-color-and-image.html
css3/blending/background-blend-mode-crossfade-image.html
css3/blending/background-blend-mode-background-repeat-no-repeat.html
css3/blending/background-blend-mode-background-attachement-fixed.html
css3/blending/background-blend-mode-background-size-cover.html
css3/blending/background-blend-mode-background-size-contain.html
css3/blending/background-blend-mode-tiled-layers.html
imported/blink/css3/blending/background-blend-mode-background-size-percentage.html
css3/blending/background-blend-mode-body-transparent-image.html
css3/blending/background-blend-mode-image-color-dynamic.html
css3/blending/background-blend-mode-background-clip-padding-box.html
imported/blink/css3/blending/background-blend-mode-background-size-pixels.html
css3/blending/background-blend-mode-data-uri-svg-image.html
css3/blending/background-blend-mode-background-origin-border-box.html
imported/blink/paint/masks/table-cell-masks.html
css3/blending/background-blend-mode-background-position-percentage.html
imported/blink/css3/blending/background-blend-mode-background-origin-content-box.html
Comment 8 EWS Watchlist 2018-07-18 23:31:45 PDT
Created attachment 345334 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 9 Said Abou-Hallawa 2018-07-19 09:50:32 PDT
Created attachment 345352 [details]
Patch for EWS
Comment 10 Said Abou-Hallawa 2018-07-19 10:24:09 PDT
Created attachment 345356 [details]
Patch for EWS
Comment 11 Said Abou-Hallawa 2018-07-19 10:42:50 PDT
Created attachment 345359 [details]
Patch for EWS
Comment 12 Said Abou-Hallawa 2018-07-19 11:25:52 PDT
Created attachment 345364 [details]
Patch for EWS
Comment 13 Said Abou-Hallawa 2018-07-19 11:38:55 PDT
Created attachment 345366 [details]
Patch for EWS
Comment 14 Said Abou-Hallawa 2018-07-19 14:06:38 PDT
Created attachment 345380 [details]
Patch for Review
Comment 15 Radar WebKit Bug Importer 2018-08-06 16:37:55 PDT
<rdar://problem/42986531>
Comment 16 Ahmad Saleem 2022-10-17 14:46:02 PDT
Checked with BugID, it seems this didn't landed. Is this still required? Thanks!