| Summary: | Fix message of NotSupportedError exception thrown during custom element creation | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||
| Component: | New Bugs | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, rniwa, rwlbuis, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/12053 | ||||||||||
| Bug Depends on: | 161528 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Frédéric Wang (:fredw)
2018-07-18 06:31:36 PDT
Created attachment 345241 [details]
Patch
I guess we should really have a test to verify the text, but the tests from bug 161528 just check the exceptions... Comment on attachment 345241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345241&action=review > Source/WebCore/ChangeLog:13 > + No new tests, the exceptions are already tested but the actual text is non-standard. Can we add a WebKit specific test validating these messages? Comment on attachment 345241 [details] Patch Attachment 345241 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8574796 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html Created attachment 345247 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 345340 [details]
Patch for landing
Comment on attachment 345340 [details] Patch for landing Clearing flags on attachment: 345340 Committed r233980: <https://trac.webkit.org/changeset/233980> All reviewed patches have been landed. Closing bug. (In reply to Yusuke Suzuki from comment #3) > Comment on attachment 345241 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345241&action=review > > > Source/WebCore/ChangeLog:13 > > + No new tests, the exceptions are already tested but the actual text is non-standard. > > Can we add a WebKit specific test validating these messages? Yeah, I was reluctant to duplicate existing tests but I did it when I landed this patch. |