Bug 187755

Summary: [JSC] JSON.stringify's replacer should use `isArray` instead of JSArray checks
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Yusuke Suzuki 2018-07-18 05:55:35 PDT 
[JSC] JSON.stringify's replacer should use `isArray` instead of JSArray checks
Comment 1 Yusuke Suzuki 2018-07-18 05:58:40 PDT 
Created attachment 345239 [details]
Patch
Comment 2 EWS Watchlist 2018-07-18 06:03:06 PDT 
Attachment 345239 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSONObject.cpp:236:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/runtime/JSONObject.cpp:240:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/runtime/JSONObject.cpp:243:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/runtime/JSONObject.cpp:251:  Extra space before )  [whitespace/parens] [2]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2018-07-18 11:15:47 PDT 
Comment on attachment 345239 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2018-07-18 11:17:18 PDT 
Comment on attachment 345239 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2018-07-18 11:31:15 PDT 
Comment on attachment 345239 [details]
Patch

Clearing flags on attachment: 345239

Committed r233918: <https://trac.webkit.org/changeset/233918>
Comment 6 WebKit Commit Bot 2018-07-18 11:31:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-07-18 11:32:22 PDT 
<rdar://problem/42343999>