Bug 187705

Summary: [JSC] Make SourceParseMode small
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2018-07-16 12:20:41 PDT
[JSC] Make SourceParseMode small
Comment 1 Yusuke Suzuki 2018-07-16 12:23:27 PDT
Created attachment 345108 [details]
Patch
Comment 2 Mark Lam 2018-07-16 12:33:43 PDT
Comment on attachment 345108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345108&action=review

r=me

> Source/JavaScriptCore/parser/ParserModes.h:45
> +// Keep it less tha 32, it means this should be within 5 bits.

/tha/than/.
Comment 3 Yusuke Suzuki 2018-07-16 12:48:24 PDT
Comment on attachment 345108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345108&action=review

Thank you!

>> Source/JavaScriptCore/parser/ParserModes.h:45
>> +// Keep it less tha 32, it means this should be within 5 bits.
> 
> /tha/than/.

Fixed.
Comment 4 Yusuke Suzuki 2018-07-16 12:49:19 PDT
Committed r233860: <https://trac.webkit.org/changeset/233860>
Comment 5 Radar WebKit Bug Importer 2018-07-16 13:13:20 PDT
<rdar://problem/42252920>