Bug 187705

Summary: [JSC] Make SourceParseMode small
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2018-07-16 12:20:41 PDT
[JSC] Make SourceParseMode small
Attachments
Patch (5.23 KB, patch)
2018-07-16 12:23 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-16 12:23:27 PDT
Created attachment 345108 [details] Patch
Mark Lam
Comment 2 2018-07-16 12:33:43 PDT
Comment on attachment 345108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345108&action=review r=me > Source/JavaScriptCore/parser/ParserModes.h:45 > +// Keep it less tha 32, it means this should be within 5 bits. /tha/than/.
Yusuke Suzuki
Comment 3 2018-07-16 12:48:24 PDT
Comment on attachment 345108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345108&action=review Thank you! >> Source/JavaScriptCore/parser/ParserModes.h:45 >> +// Keep it less tha 32, it means this should be within 5 bits. > > /tha/than/. Fixed.
Yusuke Suzuki
Comment 4 2018-07-16 12:49:19 PDT
Committed r233860: <https://trac.webkit.org/changeset/233860>
Radar WebKit Bug Importer
Comment 5 2018-07-16 13:13:20 PDT
<rdar://problem/42252920>
Note You need to log in before you can comment on or make changes to this bug.