| Summary: | jsc shell's noFTL utility test function should be more robust. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2018-07-16 11:04:53 PDT
Created attachment 345102 [details]
proposed patch.
Comment on attachment 345102 [details]
proposed patch.
r=me
Comment on attachment 345102 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review r=me. > Source/JavaScriptCore/jsc.cpp:1443 > + if (exec->argumentCount() >= 1) { Nit: you can just do if (exec->argumentCount()) here. Comment on attachment 345102 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review >> Source/JavaScriptCore/jsc.cpp:1443 >> + if (exec->argumentCount() >= 1) { > > Nit: you can just do if (exec->argumentCount()) here. Will fix before landing. Thanks for the review. Landed in r233854: <http://trac.webkit.org/r233854>. |