| Summary: | Shrink CompositeAnimation and AnimationBase | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dbates, dino, dstockwell, ews-watchlist, graouts, graouts, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2018-07-14 17:16:10 PDT
Created attachment 345044 [details]
Patch
Comment on attachment 345044 [details]
Patch
I was a bit puzzled by this patch since there was no explanation as to why the member variables were declared in a different spot. Ideally there would be a comment or an assertion if the class size exceeds the expected amount. Then we could refer back to this patch as good practice for memory-efficient classes.
Comment on attachment 345044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345044&action=review We may want to consider taking a similar approach as RenderStyle? and add static asserts to prevent a size regression. > Source/WebCore/ChangeLog:8 > + Reduce the size of CompositeAnimation and AnimationBase. How much did we reduce it by? Comment on attachment 345044 [details] Patch Clearing flags on attachment: 345044 Committed r233908: <https://trac.webkit.org/changeset/233908> All reviewed patches have been landed. Closing bug. |