Bug 187680

Summary: Shrink some style-related classes and enums
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2018-07-14 16:12:03 PDT
Shrink some style-related classes and enums
Comment 1 Simon Fraser (smfr) 2018-07-14 16:17:42 PDT
Created attachment 345040 [details]
Patch
Comment 2 Antti Koivisto 2018-07-14 16:31:22 PDT
Comment on attachment 345040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345040&action=review

> Source/WebCore/ChangeLog:12
> +        Shrink DocumentRuleSet from 384 to 368 bytes by re-ordering, which also helps shrink
> +        StyleResolver from 1024 to 952 bytes.

Micro-optimizing low volume objects like DocumentRuleSet does not produce meaningful gain. Still, cleanups are nice.
Comment 3 WebKit Commit Bot 2018-07-14 17:29:35 PDT
Comment on attachment 345040 [details]
Patch

Clearing flags on attachment: 345040

Committed r233838: <https://trac.webkit.org/changeset/233838>
Comment 4 WebKit Commit Bot 2018-07-14 17:29:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-07-14 17:30:30 PDT
<rdar://problem/42207689>