| Summary: | [ews-build] Add build step to run layout-test | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=188498 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2018-07-13 17:11:56 PDT
Created attachment 345006 [details]
Proposed patch
Adding the simple build step for running layout tests. This is quite similar to current EWS.
Further enhancements like retrying layout-tests on failure, analyzing the results etc. would be in separate patch.
Attachment 345006 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:730: [TestRunWebKitTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:730: [TestRunWebKitTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:744: [TestRunWebKitTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:744: [TestRunWebKitTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 4 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Style queue warnings are false positive. Comment on attachment 345006 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=345006&action=review r=me, after considering typo fix. > Tools/BuildSlaveSupport/ews-build/steps.py:264 > + name = 'layout-test' should this be 'layout-tests' ? Committed r233921: <https://trac.webkit.org/changeset/233921> |