| Summary: | Ensure WebKit stack is ad-hoc signed | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kocsen Chung <kocsen_chung> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ap, dino, eric.carlson, ews-watchlist, graouts, kondapallykalyan, mitz, rniwa | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Kocsen Chung
2018-07-13 15:49:49 PDT
Created attachment 344997 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Attachment 344997 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 344999 [details]
Patch
Comment on attachment 344999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344999&action=review Looks reasonable to me. I'm not sure what's up with mac-wk2 EWS. Probably the machine is in a bad state, but who knows what repercussions this patch has. > Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:3 > +CODE_SIGN_IDENTITY = - ; I wouldn't be adding spaces before the semicolon. Comment on attachment 344999 [details] Patch Attachment 344999 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8531181 Number of test failures exceeded the failure limit. Created attachment 345009 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 344999 [details] Patch Attachment 344999 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8532721 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html Created attachment 345017 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Tested locally, and WebKit2 tests pass. Must have been a bot condition. Committed http://trac.webkit.org/r233837 |