Bug 187665

Summary: Add _drawsBackground to WKWebViewConfiguration
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit APIAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ews-watchlist, rniwa, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews106 for mac-sierra-wk2 none

Timothy Hatcher
Reported 2018-07-13 14:56:25 PDT
WebViews that need to be transparent often flash white before _drawsBackground can be set to NO on the WKWebView. Add _drawsBackground to WKWebViewConfiguration so it can be passed in at instantiation.
Attachments
Patch (12.10 KB, patch)
2018-07-13 15:22 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (12.16 KB, patch)
2018-07-13 15:49 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.70 MB, application/zip)
2018-07-13 16:42 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-13 14:57:03 PDT
<rdar://problem/42182268>
Tim Horton
Comment 2 2018-07-13 15:19:34 PDT
Why do they flash? It’s in WebPageCreationParameters, so as long as it’s set *before* clients load (and thus launch a process) (and also as long as they do it in the same runloop as they create the view), shouldn’t that be sufficient?
Timothy Hatcher
Comment 3 2018-07-13 15:22:29 PDT Comment hidden (obsolete)
Anders Carlsson
Comment 4 2018-07-13 15:23:40 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 5 2018-07-13 15:49:16 PDT
Created attachment 344996 [details] Patch
Tim Horton
Comment 6 2018-07-13 16:06:46 PDT
Comment on attachment 344996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344996&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:45 > +TEST(WebKit, ConfigurationDrawsBackground) Tests! Crazy.
EWS Watchlist
Comment 7 2018-07-13 16:42:36 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 8 2018-07-13 16:42:38 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 9 2018-07-13 17:03:55 PDT
Comment on attachment 344996 [details] Patch Clearing flags on attachment: 344996 Committed r233828: <https://trac.webkit.org/changeset/233828>
WebKit Commit Bot
Comment 10 2018-07-13 17:03:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.