Bug 187648

Summary: [ MacOS iOS ] Layout Test storage/indexeddb/modern/opendatabase-after-storage-crash.html is flaky
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Tools / TestsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, ap, beidson, cdumez, commit-queue, ddorwin, ews-watchlist, jsbell, lforschler, rniwa, ryanhaddad, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch none

Comment 1 Alexey Proskuryakov 2018-07-17 15:34:02 PDT 
Looks like it's failing about half of the time now.

@@ -1 +1 @@
-Successfully opened the database in a new document
+Unexpected success during the first database open on document load. DB opening: opendatabase-after-storage-crash.htmlTue Jul 17 2018 12:03:43 GMT-0700 (PDT). Version opening: 1. SessionStorage value: undefined
Comment 2 Brady Eidson 2018-07-17 16:31:10 PDT 
I've tried to fix this a few times.

It's current inexplicable to me why the failure that is still happening is possible.

*sigh*
Comment 3 Ryan Haddad 2018-07-19 16:30:40 PDT 
Marked test as flaky in https://trac.webkit.org/r234015.
Comment 4 Radar WebKit Bug Importer 2018-07-19 16:31:31 PDT 
<rdar://problem/42405935>
Comment 5 Sihui Liu 2018-07-19 18:07:35 PDT 
Created attachment 345413 [details]
Patch
Comment 6 Brady Eidson 2018-07-20 16:46:59 PDT 
Comment on attachment 345413 [details]
Patch

You should remove the mark-as-flaky
Comment 7 Sihui Liu 2018-07-20 17:02:16 PDT 
Created attachment 345490 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-07-20 17:41:52 PDT 
Comment on attachment 345490 [details]
Patch for landing

Clearing flags on attachment: 345490

Committed r234077: <https://trac.webkit.org/changeset/234077>
Comment 9 WebKit Commit Bot 2018-07-20 17:41:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Truitt Savell 2018-08-06 09:21:40 PDT 
after https://trac.webkit.org/changeset/234077 We began to see tests in the svg/ directory begin to flake randomly. 

This issue is detailed in https://bugs.webkit.org/show_bug.cgi?id=187931

I found that after this change to storage/indexeddb/modern/opendatabase-after-storage-crash.html that this test would set a state that caused any test in the svg/ directory to have a chance of timeout. 

I have skipped this test in: 
https://trac.webkit.org/changeset/234602/webkit
Comment 11 Sihui Liu 2018-08-06 17:07:47 PDT 
Created attachment 346666 [details]
Patch
Comment 12 Sihui Liu 2018-08-09 11:29:16 PDT 
Created attachment 346852 [details]
Patch
Comment 13 WebKit Commit Bot 2018-08-24 17:38:44 PDT 
Comment on attachment 346852 [details]
Patch

Rejecting attachment 346852 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 346852, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=346852&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=187648&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 346852 from bug 187648.
Fetching: https://bugs.webkit.org/attachment.cgi?id=346852
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/wk2/TestExpectations
	M	LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: eed6554d82f4ac9a175e722742f09c327e278291 and refs/remotes/origin/master differ, using rebase:
:040000 040000 c39453c186f0451c3e13da98f776e98f671cdf31 9631be1100237ff43f4ef7c0005cc5185c77722d M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/wk2/TestExpectations
	M	LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: eed6554d82f4ac9a175e722742f09c327e278291 and refs/remotes/origin/master differ, using rebase:
:040000 040000 c39453c186f0451c3e13da98f776e98f671cdf31 9631be1100237ff43f4ef7c0005cc5185c77722d M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.
Total errors found: 0 in 1 files

Full output: https://webkit-queues.webkit.org/results/8977468
Comment 14 WebKit Commit Bot 2018-08-27 17:35:35 PDT 
Comment on attachment 346852 [details]
Patch

Clearing flags on attachment: 346852

Committed r235415: <https://trac.webkit.org/changeset/235415>
Comment 15 WebKit Commit Bot 2018-08-27 17:35:37 PDT 
All reviewed patches have been landed.  Closing bug.