Bug 187647

Summary: Add more threading release assertions
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Description Chris Dumez 2018-07-13 10:13:39 PDT
Add more threading release assertions to help debug <rdar://problem/39265927>.
Comment 1 Chris Dumez 2018-07-13 10:15:09 PDT
Created attachment 344951 [details]
Patch
Comment 2 Chris Dumez 2018-07-13 10:17:51 PDT
Created attachment 344952 [details]
Patch
Comment 3 Alex Christensen 2018-07-13 11:43:27 PDT
Comment on attachment 344952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344952&action=review

> Source/WebKit/UIProcess/WebProcessProxy.cpp:760
> +    RELEASE_ASSERT(RunLoop::isMain());

All the other assertions are at the beginning of the function.
Comment 4 Chris Dumez 2018-07-13 11:47:26 PDT
Committed r233808: <https://trac.webkit.org/changeset/233808>
Comment 5 Radar WebKit Bug Importer 2018-07-13 11:48:20 PDT
<rdar://problem/42174774>