| Summary: | Release test-262 tests failed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dawei Fenton (:realdawei) <realdawei> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED WORKSFORME | ||||||
| Severity: | Normal | CC: | ap, leo, lforschler, mark.lam, msaboff, ryanhaddad, tsavell, valerie, ysuzuki | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dawei Fenton (:realdawei)
2018-07-13 08:28:11 PDT
I think that test is expected to fail, as subsequent runs have passed even though that same error appears. (In reply to David Fenton (:realdawei) from comment #0) > https://build.webkit.org/builders/ > Apple%20Sierra%20Release%20Test262%20%28Tests%29/builds/3408/steps/test262- > test/logs/stdio This run doesn't show a summary at the end, and I see 'process killed by signal 13', so it looks like something prevented the script from completing. (In reply to Ryan Haddad from comment #2) > (In reply to David Fenton (:realdawei) from comment #0) > > https://build.webkit.org/builders/ > > Apple%20Sierra%20Release%20Test262%20%28Tests%29/builds/3408/steps/test262- > > test/logs/stdio > > This run doesn't show a summary at the end, and I see 'process killed by > signal 13', so it looks like something prevented the script from completing. True, I see that's it run successfully twice since, so closing the bug. Looking at this queues history, it looks like the tests have failed this way 4 times out of the last 200 runs. I'm not sure under what conditions this reproduces. I haven't tried locally. CC'ing Leo and Valerie for visibility. heh, that's probably a bug in JSC. As far as I checked here, JSC should definitely pass for this test case, but:
```
>>> a = Function("<!--", "");
Exception: SyntaxError: Unexpected token '}'. Expected a parameter pattern or a ')' in parameter list.
```
If it passes, the following is expected:
```
a.toString();
/*--
"function anonymous(<!--
) {
}"
--*/
```
The same bug happens when we try it with a regular inline comment:
```
Function('//', '')
```
The inline comment should not affect the function body, but only consequent parameters.
I checked that other major engines are working as expected.
Should this be re-opened? Or perhaps it's better to have a new bug that clearly describes the issue? This one has a title that isn't super descriptive. |