Bug 187612

Summary: Web Inspector: Type token positioning should use line/column locations from Esprima instead of offsets
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 186453, 187532    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Description Matt Baker 2018-07-12 12:00:54 PDT 
Summary:
Type token positioning should use line/column locations from Esprima instead of offsets.

TypeTokenAnnotator calculates positions for type tokens using offsets from Esprima AST nodes. Once CodeMirror returns to auto-detecting line endings (see https://webkit.org/b/186453), these offsets won't correspond to CodeMirror's offsets for the same tokens.
Comment 1 Radar WebKit Bug Importer 2018-07-12 12:10:16 PDT 
<rdar://problem/42131910>
Comment 2 Matt Baker 2018-07-12 12:23:17 PDT 
Created attachment 344872 [details]
Patch
Comment 3 EWS Watchlist 2018-07-12 15:10:08 PDT 
Comment on attachment 344872 [details]
Patch

Attachment 344872 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8519412

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 EWS Watchlist 2018-07-12 15:10:20 PDT 
Created attachment 344887 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Joseph Pecoraro 2018-07-12 16:45:08 PDT 
Comment on attachment 344872 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-07-12 19:06:55 PDT 
Comment on attachment 344872 [details]
Patch

Clearing flags on attachment: 344872

Committed r233792: <https://trac.webkit.org/changeset/233792>
Comment 7 WebKit Commit Bot 2018-07-12 19:06:56 PDT 
All reviewed patches have been landed.  Closing bug.