Bug 187600

Summary: [GStreamer] Add GstBufferMapped abstraction
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Charlie Turner 2018-07-12 07:12:19 PDT 
[GStreamer] Add GstBufferMapped abstraction
Comment 1 Charlie Turner 2018-07-12 07:16:02 PDT 
Created attachment 344841 [details]
Patch
Comment 2 EWS Watchlist 2018-07-12 07:17:17 PDT 
Attachment 344841 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Charlie Turner 2018-07-12 07:22:22 PDT 
Created attachment 344842 [details]
Patch
Comment 4 Xabier Rodríguez Calvar 2018-07-13 00:43:31 PDT 
Comment on attachment 344842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344842&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:303
> +                gst_byte_reader_free(reader);

Interesting catch! We should do this (not necessarily now) a GUniquePtr.
Comment 5 WebKit Commit Bot 2018-07-13 01:10:58 PDT 
Comment on attachment 344842 [details]
Patch

Clearing flags on attachment: 344842

Committed r233796: <https://trac.webkit.org/changeset/233796>
Comment 6 WebKit Commit Bot 2018-07-13 01:11:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Philippe Normand 2018-08-16 01:30:42 PDT 
*** Bug 187586 has been marked as a duplicate of this bug. ***