Bug 187559

Summary: REGRESSION (r233714): JSC test stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js is timing out
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: REOPENED ---    
Severity: Normal CC: ap, fpizlo, realdawei, saam, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187540

Description Ryan Haddad 2018-07-11 13:03:52 PDT 
JSC test stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js is timing out on Release and Debug bots:

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20JSC%20%28Tests%29/builds/4762

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/1251
Comment 1 Ryan Haddad 2018-07-11 13:05:22 PDT 
This was the only JSC change in that range:

"Change the reoptimization backoff base to 1.3 from 2"
https://trac.webkit.org/changeset/233714/webkit
Comment 2 Filip Pizlo 2018-07-11 13:37:50 PDT 
(In reply to Ryan Haddad from comment #1)
> This was the only JSC change in that range:
> 
> "Change the reoptimization backoff base to 1.3 from 2"
> https://trac.webkit.org/changeset/233714/webkit

We should skip the test then.

Just add:

"//@ skip"

to the top of the .js file.
Comment 3 Ryan Haddad 2018-07-11 14:10:27 PDT 
Skipped in https://trac.webkit.org/r233743
Comment 4 Radar WebKit Bug Importer 2018-07-11 14:16:30 PDT 
<rdar://problem/42088527>
Comment 5 Alexey Proskuryakov 2018-07-12 09:56:10 PDT 
Why is this is marked RESOLVED, don't we want to make the test work again? If not, it should be deleted, not skipped. But it seems like a real test for a real important bug.
Comment 6 Alexey Proskuryakov 2018-07-12 09:57:24 PDT 
Re-opening.