| Summary: | Disable all network caching for HLS streams. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, koivisto, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2018-07-10 17:46:06 PDT
Created attachment 344740 [details]
Patch
Created attachment 344743 [details]
Patch
Comment on attachment 344743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344743&action=review > Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:661 > + return NO; I am not sure this is sufficient to disable caching in the NetworkProcess. Maybe setting FetchOptions.cache to FetchOptions::Cache::NoStore in MediaResourceLoader when we return NO here would do the trick. Created attachment 344774 [details]
Patch
Comment on attachment 344774 [details] Patch Clearing flags on attachment: 344774 Committed r233738: <https://trac.webkit.org/changeset/233738> All reviewed patches have been landed. Closing bug. Comment on attachment 344774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344774&action=review > Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:265 > // FIXME: We should introduce a separate media cache partition that doesn't affect other resources. > // FIXME: We should also make sure make the MSE paths are copy-free so we can use mapped buffers from disk effectively. These FIXMEs don't make much sense now either and could be removed. |