Bug 187544

Summary: Disable all network caching for HLS streams.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, koivisto, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jer Noble
Reported 2018-07-10 17:46:06 PDT
Disable all network caching for HLS streams.
Attachments
Patch (2.84 KB, patch)
2018-07-10 17:48 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (3.86 KB, patch)
2018-07-10 18:22 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2018-07-11 11:43 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-07-10 17:46:23 PDT
<rdar://problem/41863600>
Jer Noble
Comment 2 2018-07-10 17:48:54 PDT
Created attachment 344740 [details] Patch
Jer Noble
Comment 3 2018-07-10 18:22:00 PDT
Created attachment 344743 [details] Patch
youenn fablet
Comment 4 2018-07-10 19:23:09 PDT
Comment on attachment 344743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344743&action=review > Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:661 > + return NO; I am not sure this is sufficient to disable caching in the NetworkProcess. Maybe setting FetchOptions.cache to FetchOptions::Cache::NoStore in MediaResourceLoader when we return NO here would do the trick.
Jer Noble
Comment 5 2018-07-11 11:43:19 PDT
Created attachment 344774 [details] Patch
WebKit Commit Bot
Comment 6 2018-07-11 12:30:06 PDT
Comment on attachment 344774 [details] Patch Clearing flags on attachment: 344774 Committed r233738: <https://trac.webkit.org/changeset/233738>
WebKit Commit Bot
Comment 7 2018-07-11 12:30:08 PDT
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 8 2018-07-11 16:09:13 PDT
Comment on attachment 344774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344774&action=review > Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:265 > // FIXME: We should introduce a separate media cache partition that doesn't affect other resources. > // FIXME: We should also make sure make the MSE paths are copy-free so we can use mapped buffers from disk effectively. These FIXMEs don't make much sense now either and could be removed.
Note You need to log in before you can comment on or make changes to this bug.