| Summary: | WebGL contexts unable to detect correct display upon first WebProcess creation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||
| Component: | WebGL | Assignee: | Justin Fan <justin_fan> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | commit-queue, dino, simon.fraser, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Justin Fan
2018-07-09 16:58:07 PDT
Created attachment 344642 [details]
Patch
Comment on attachment 344642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344642&action=review > Source/WebKit/Shared/WebPageCreationParameters.h:142 > + uint32_t displayID; Shouldn’t this be a PlatformDisplayID? Comment on attachment 344642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344642&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:6192 > + parameters.displayID = mainScreenDisplayID(); But this might not be the screen that at the window is on. Comment on attachment 344642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344642&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:6192 >> + parameters.displayID = mainScreenDisplayID(); > > But this might not be the screen that at the window is on. Get it from pageClient instead! There’s a nontrivial chance we have a parented view at this point. Comment on attachment 344642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344642&action=review > Source/WebCore/ChangeLog:6 > + __ up here > Source/WebCore/ChangeLog:15 > + Reviewed by NOBODY (OOPS!). What’s this doing all the way down here? Should be ^^. Comment on attachment 344642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344642&action=review >> Source/WebKit/Shared/WebPageCreationParameters.h:142 >> + uint32_t displayID; > > Shouldn’t this be a PlatformDisplayID? It's a using alias for uint32_t in PlatformScreen.h; should I bring in PlatformScreen.h or re-alias it in this header? >>> Source/WebKit/UIProcess/WebPageProxy.cpp:6192 >>> + parameters.displayID = mainScreenDisplayID(); >> >> But this might not be the screen that at the window is on. > > Get it from pageClient instead! There’s a nontrivial chance we have a parented view at this point. Will try! |