| Summary: | [JSC] Optimize layout of AccessCase / ProxyableAccessCase to reduce size of ProxyableAccessCase | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, simon.fraser, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Yusuke Suzuki
2018-07-09 04:33:04 PDT
Created attachment 344573 [details]
Patch
Created attachment 344575 [details]
Patch
Created attachment 344576 [details]
Patch
Comment on attachment 344576 [details] Patch Attachment 344576 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8481820 New failing tests: animations/needs-layout.html Created attachment 344580 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 344582 [details]
Patch
Created attachment 344583 [details]
Patch
Comment on attachment 344583 [details]
Patch
r=me.
Comment on attachment 344583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344583&action=review > Source/JavaScriptCore/bytecode/AccessCase.h:246 > + // It becomes true only if the instance inherits (or it is) ProxyableAccessCase. nit: It bocomes true => m_viaProxy is true > Source/JavaScriptCore/bytecode/AccessCase.h:248 > + // derived classes, which is super frequently allocated. nit: which is => which are. Comment on attachment 344583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344583&action=review Thanks! >> Source/JavaScriptCore/bytecode/AccessCase.h:246 >> + // It becomes true only if the instance inherits (or it is) ProxyableAccessCase. > > nit: It bocomes true => m_viaProxy is true Fixed. >> Source/JavaScriptCore/bytecode/AccessCase.h:248 >> + // derived classes, which is super frequently allocated. > > nit: which is => which are. Fixed. Committed r233644: <https://trac.webkit.org/changeset/233644> |