Bug 187441

Summary: [JSC] Optimize layout of CodeBlock to reduce padding
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Description Yusuke Suzuki 2018-07-07 14:36:31 PDT 
[JSC] Optimize layout of CodeBlock to reduce padding
Comment 1 Yusuke Suzuki 2018-07-07 14:41:53 PDT 
Created attachment 344529 [details]
Patch
Comment 2 EWS Watchlist 2018-07-07 14:43:35 PDT 
Attachment 344529 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:375:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 3 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2018-07-07 14:59:44 PDT 
Comment on attachment 344529 [details]
Patch

r=me
Comment 4 EWS Watchlist 2018-07-07 16:45:12 PDT 
Comment on attachment 344529 [details]
Patch

Attachment 344529 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8469324

New failing tests:
animations/needs-layout.html
Comment 5 EWS Watchlist 2018-07-07 16:45:14 PDT 
Created attachment 344532 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 WebKit Commit Bot 2018-07-08 10:59:32 PDT 
Comment on attachment 344529 [details]
Patch

Clearing flags on attachment: 344529

Committed r233630: <https://trac.webkit.org/changeset/233630>
Comment 7 WebKit Commit Bot 2018-07-08 10:59:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-08 11:02:15 PDT 
<rdar://problem/41950526>
Comment 9 Yusuke Suzuki 2018-07-08 21:37:30 PDT 
Committed r233633: <https://trac.webkit.org/changeset/233633>