Bug 187419

Summary: [Curl] Remove unused AuthenticationManager static methods.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, ews-watchlist, fujii.hironori, rniwa, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-sierra
none
PATCH none

Basuke Suzuki
Reported 2018-07-06 15:47:53 PDT
These are not implemented and added accidentally.
Attachments
PATCH (3.40 KB, patch)
2018-07-06 15:59 PDT, Basuke Suzuki 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.32 MB, application/zip)
2018-07-06 16:50 PDT, EWS Watchlist 		no flags
Details
PATCH (4.53 KB, patch)
2018-07-09 11:38 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-07-06 15:59:03 PDT
Created attachment 344472 [details] PATCH I assume we can remove these static method declarations from Source/WebKit/Shared/Authentication/AuthenticationManager.h: static void receivedCredential(const WebCore::AuthenticationChallenge&, const WebCore::Credential&); static void receivedRequestToContinueWithoutCredential(const WebCore::AuthenticationChallenge&); static void receivedCancellation(const WebCore::AuthenticationChallenge&); static void receivedRequestToPerformDefaultHandling(const WebCore::AuthenticationChallenge&); static void receivedChallengeRejection(const WebCore::AuthenticationChallenge&);
EWS Watchlist
Comment 2 2018-07-06 16:50:34 PDT
Comment on attachment 344472 [details] PATCH Attachment 344472 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8461431 New failing tests: media/media-fullscreen-return-to-inline.html
EWS Watchlist
Comment 3 2018-07-06 16:50:35 PDT
Created attachment 344488 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Fujii Hironori
Comment 4 2018-07-08 22:07:31 PDT
Curl port is the only port to implement the class methods. You can remove the declarations. https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h?rev=232613#L83
Basuke Suzuki
Comment 5 2018-07-09 11:38:47 PDT
Created attachment 344599 [details] PATCH
Basuke Suzuki
Comment 6 2018-07-09 11:40:52 PDT
(In reply to Fujii Hironori from comment #4) > Curl port is the only port to implement the class methods. > You can remove the declarations. > https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Shared/ > Authentication/AuthenticationManager.h?rev=232613#L83 Thanks for confirmation.
Yusuke Suzuki
Comment 7 2018-07-09 11:42:24 PDT
Comment on attachment 344599 [details] PATCH r=me
Basuke Suzuki
Comment 8 2018-07-09 12:06:03 PDT
Thanks, Yusuke.
WebKit Commit Bot
Comment 9 2018-07-09 12:23:25 PDT
The commit-queue encountered the following flaky tests while processing attachment 344599 [details]: media/media-fullscreen-pause-inline.html bug 187387 (author: jeremyj-wk@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2018-07-09 12:23:37 PDT
The commit-queue encountered the following flaky tests while processing attachment 344599 [details]: media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2018-07-09 12:33:33 PDT
Comment on attachment 344599 [details] PATCH Clearing flags on attachment: 344599 Committed r233654: <https://trac.webkit.org/changeset/233654>
WebKit Commit Bot
Comment 12 2018-07-09 12:33:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-07-09 12:34:19 PDT
<rdar://problem/41984802>
Note You need to log in before you can comment on or make changes to this bug.