| Summary: | iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Olivia Barnett <obarnett> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=196102 | ||||||||
| Attachments: |
|
||||||||
|
Description
Olivia Barnett
2018-07-05 14:40:08 PDT
Created attachment 344368 [details]
Patch
Comment on attachment 344368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344368&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3686 > + if (_assistedNodeInformation.elementType != InputType::Select) { I don't think this is quite right, because pageup/pagedown and spacebar will still scroll. Instead, I think you should bail at the top of the function similar to what we do in the isContentEditable case. Created attachment 344374 [details]
Patch
Comment on attachment 344374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344374&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3645 > + if (_assistedNodeInformation.elementType == InputType::Select) We probably want to add other types to this list (are there other kinds of assisted nodes that use popovers?), but this is a good start. Comment on attachment 344374 [details] Patch Clearing flags on attachment: 344374 Committed r233553: <https://trac.webkit.org/changeset/233553> All reviewed patches have been landed. Closing bug. |