Bug 187359

Summary: ProgramExecutable may be collected as we checkSyntax on it
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2018-07-05 12:53:09 PDT 
The reason this is bad is we call into various functions with a  reference to one of ProgramExecutable's fields.
We either need to:
- drop in a use() on it 
- Copy the field instead of passing a reference
- defer GC
(I like the first option)

This is already caught by our iOS JSC testing on various tests.
Comment 1 Saam Barati 2018-07-05 13:21:02 PDT 
Actually, let's do (2)
Comment 2 Saam Barati 2018-07-05 13:28:15 PDT 
<rdar://problem/41832135>
Comment 3 Saam Barati 2018-07-05 13:35:15 PDT 
Created attachment 344358 [details]
patch
Comment 4 Mark Lam 2018-07-05 13:36:26 PDT 
Comment on attachment 344358 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2018-07-05 14:35:16 PDT 
Comment on attachment 344358 [details]
patch

Clearing flags on attachment: 344358

Committed r233540: <https://trac.webkit.org/changeset/233540>
Comment 6 WebKit Commit Bot 2018-07-05 14:35:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Mark Lam 2018-07-19 12:44:34 PDT 
*** Bug 187812 has been marked as a duplicate of this bug. ***
Comment 8 Mark Lam 2018-07-19 12:45:11 PDT 
*** Bug 187811 has been marked as a duplicate of this bug. ***