Bug 187350

Summary:

REGRESSION: Web Inspector no longer pauses in internal injected scripts like WDFindNodes.js

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mattbaker, msaboff, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	mattbaker: review+

Description BJ Burg 2018-07-05 10:49:34 PDT

This seems to be fallout from internal script black boxing.

Comment 1 BJ Burg 2018-07-05 10:49:56 PDT

<rdar://problem/41728249>

Comment 2 BJ Burg 2018-07-05 11:00:05 PDT

Created attachment 344343 [details]
Patch

Comment 3 Matt Baker 2018-07-09 09:54:57 PDT

Comment on attachment 344343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344343&action=review

r=me

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:887
> +void InspectorDebuggerAgent::setPauseForInternalScripts(ErrorString &, bool shouldPause)

Style: pointer types and reference types should be written with no space between the type name and the * or & (https://webkit.org/code-style-guidelines/#pointers-cpp)

> Source/WebInspectorUI/UserInterface/Base/Setting.js:136
> +    pauseForInternalScripts: new WI.Setting("pause-for-internal-scripts", false),

Nice cleanup.

Comment 4 BJ Burg 2018-07-09 13:00:41 PDT

Committed r233655: <https://trac.webkit.org/changeset/233655>