| Summary: | [JSC] Remove getTypedArrayImpl | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2018-07-05 02:59:48 PDT
Created attachment 344314 [details]
Patch
Attachment 344314 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:309: Non-label code inside switch statements should be indented. [whitespace/indent] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 344314 [details] Patch Attachment 344314 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8443412 New failing tests: animations/needs-layout.html Created attachment 344318 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 344314 [details] Patch Attachment 344314 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8443507 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html Created attachment 344320 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Ping? Comment on attachment 344314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344314&action=review r=me. > Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:315 > + ASSERT_NOT_REACHED(); > + return nullptr; You should make this a RELEASE_ASSERT_NOT_REACHED(). It's the equivalent of JSCell::getTypedArrayImpl() that is now removed. Comment on attachment 344314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344314&action=review Thanks! >> Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:315 >> + return nullptr; > > You should make this a RELEASE_ASSERT_NOT_REACHED(). It's the equivalent of JSCell::getTypedArrayImpl() that is now removed. Nice, fixed. Committed r233721: <https://trac.webkit.org/changeset/233721> |