Bug 187336

Summary: REGRESSION(r233495) [cairo] drawGlyphsShadow should use the fast path for zero blur-radius
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKitGTKAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, ews-watchlist, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Description Fujii Hironori 2018-07-05 01:03:35 PDT 
REGRESSION(r233495) [cairo] drawGlyphsShadow should use the fast path for zero blur-radius

drawGlyphsShadow has a fast path to draw a shadow without a
shadow layer. Since r233495, it is not used for zero blur-radius shadow.

In Bug 187244, I changed ShadowState::isRequired to return true
for zero blur-radius. This is not a right fix.
Comment 1 Fujii Hironori 2018-07-05 01:30:34 PDT 
Created attachment 344312 [details]
Patch
Comment 2 EWS Watchlist 2018-07-05 05:30:13 PDT 
Comment on attachment 344312 [details]
Patch

Attachment 344312 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8443647

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 3 EWS Watchlist 2018-07-05 05:30:25 PDT 
Created attachment 344321 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Fujii Hironori 2018-07-05 18:57:17 PDT 
Comment on attachment 344312 [details]
Patch

Clearing flags on attachment: 344312

Committed r233556: <https://trac.webkit.org/changeset/233556>
Comment 5 Fujii Hironori 2018-07-05 18:57:22 PDT 
All reviewed patches have been landed.  Closing bug.