| Summary: | [ews-build] WebKitPy-Tests-EWS should output result in json | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, ddkilzer, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=187148 https://bugs.webkit.org/show_bug.cgi?id=189417 |
||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2018-07-04 14:01:19 PDT
Created attachment 344300 [details] Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/16/builds/26 Comment on attachment 344300 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=344300&action=review r=me > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:313 > + command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'], > + logfiles={'json': 'webkitpy_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py. > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:326 > + command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'], > + logfiles={'json': 'webkitpy_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py. (In reply to David Kilzer (:ddkilzer) from comment #2) > Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done > in steps.py. Sure, will re-use the variable. Committed r233527: <https://trac.webkit.org/changeset/233527>. |